[rust-compiler] Propagate block lowering errors (#37364)
GitHub Commits - Example: React

[rust-compiler] Propagate block lowering errors (#37364)

Commit 0bbf024 authored [rust-compiler] Propagate block lowering errors (#37364) Propagate errors from block lowering instead of continuing with incomplete HIR. This prevents the Rust compiler from emitting partial output when it encounters unsupported syntax, including nested TypeScript this parameters. This landed earlier as #37232, which exposed an existing FBT diagnostic ordering issue. Resolve local FBT bindings before checking whether an tag comes from a module import, so the compiler reports the earlier, more useful Todo instead of a later invariant. Run from the repository root: - yarn --cwd compiler workspace babel-plugin-react-compiler-rust test - cargo test --manifest-path compiler/Cargo.toml -p react_compiler_lowering1 parent f4e439e commit 0bbf024 2 files changed Lines changed: 38 additions & 27 deletions Lines changed: 21 additions & 14 deletions | Original file line number | Diff line number | Diff line change | | |---|---|---|---| | ||| 2055 | 2055 | | | 2056 | 2056 | | | 2057 | 2057 | | | 2058 | | - | | 2059 | 2058 | | | 2060 | 2059 | | | 2061 | 2060 | | | 2062 | 2061 | | | 2063 | | - | | 2064 | | - | | 2065 | | - | | 2066 | | - | | 2067 | | - | | 2068 | | - | | 2069 | | - | | 2070 | | - | | 2071 | | - | | | 2062 | + | | | 2063 | + | | | 2064 | + | | | 2065 | + | | | 2066 | + | | | 2067 | + | | | 2068 | + | | | 2069 | + | | | 2070 | + | | 2072 | 2071 | | | 2073 | 2072 | | | 2074 | 2073 | | | | ||| 2589 | 2588 | | | 2590 | 2589 | | | 2591 | 2590 | | | 2592 | | - | | 2593 | | - | | | 2591 | + | | | 2592 | + | | | 2593 | + | | | 2594 | + | | | 2595 | + | | | 2596 | + | | 2594 | 2597 | | | 2595 | 2598 | | | 2596 | 2599 | | | 2597 | 2600 | | | 2598 | 2601 | | | 2599 | 2602 | | | 2600 | 2603 | | | 2601 | | - | | 2602 | | - | | | 2604 | + | | | 2605 | + | | | 2606 | + | | | 2607 | + | | | 2608 | + | | | 2609 | + | | 2603 | 2610 | | | 2604 | 2611 | | | 2605 | 2612 | | | | Lines changed: 17 additions & 13 deletions | Original file line number | Diff line number | Diff line change | | |---|---|---|---| | ||| 741 | 741 | | | 742 | 742 | | | 743 | 743 | | | 744 | | - | | 745 | | - | | 746 | | - | | 747 | | - | | 748 | | - | | | 744 | + | | | 745 | + | | | 746 | + | | | 747 | + | | | 748 | + | | | 749 | + | | | 750 | + | | 749 | 751 | | | 750 | | - | | | 752 | + | | 751 | 753 | | | 752 | | - | | 753 | | - | | 754 | | - | | 755 | | - | | | 754 | + | | | 755 | + | | | 756 | + | | | 757 | + | | 756 | 758 | | | 757 | | - | | | 759 | + | | | 760 | + | | | 761 | + | | 758 | 762 | | | 759 | | - | | | 763 | + | | 760 | 764 | | | 761 | 765 | | | 762 | 766 | | | | ||| 891 | 895 | | | 892 | 896 | | | 893 | 897 | | | 894 | | - | | | 898 | + | | 895 | 899 | | | 896 | 900 | | | 897 | 901 | | | | 0 commit comments

Comments

No comments yet. Start the discussion.